Repository navigation
Scroll to what a car's short screen hides before waiting on it - #13
Merged
Merged
Conversation
On the Android Automotive 15 emulator, 1024x768 under the car's bars, 11 of 26 tests failed waiting on elements below the fold or reaching the gift card, the catalog's last, past fifteen scrolls. wait_for does not scroll. Each wait on such an element now scrolls to it first; the gift card is reached through its category. The sort test waits on the first row's cards, not their prices, with no scroll, so a wrong order still fails. 26 of 26 pass on the car, the Pixel 7 AVD and the iPhone 17 Pro simulator (iOS 26.5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Android Automotive 15 emulator (1024x768, under the car's bars), 11 of 26 tests failed: their wait_for targets were below the fold, and the gift card, the catalog's last, was past fifteen scrolls. wait_for does not scroll.
scroll_tobefore each wait on such an element; on a phone it answers at once.26 of 26 pass on the car, a Pixel 7 AVD (Android 15) and an iPhone 17 Pro simulator (iOS 26.5). Each changed test with a seeded bug fails with that bug on.